Skip to content

fix: alignment of the close icon in sd-tag inside sd-combobox parts#2873

Merged
martascorreia merged 10 commits intomainfrom
fix/close-icon-combobox-parts-screenshot-test
Apr 15, 2026
Merged

fix: alignment of the close icon in sd-tag inside sd-combobox parts#2873
martascorreia merged 10 commits intomainfrom
fix/close-icon-combobox-parts-screenshot-test

Conversation

@martascorreia
Copy link
Copy Markdown
Contributor

Description:

Closes: #2849

Definition of Reviewable:

  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 23, 2026

🦋 Changeset detected

Latest commit: f06dada

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-design-system/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 23, 2026

🚀 Storybook has been deployed for branch fix_close-icon-combobox-parts-screenshot-test

@tega-ekakitie
Copy link
Copy Markdown

@martascorreia Looks good to me
Screenshot 2026-03-26 at 08 26 36

@tega-ekakitie tega-ekakitie removed their assignment Mar 26, 2026
Copy link
Copy Markdown
Contributor

@MartaPintoTeixeira MartaPintoTeixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As spoken please check comment on VB cromatic

@MartaPintoTeixeira MartaPintoTeixeira removed their assignment Apr 10, 2026
@coraliefeil coraliefeil removed their assignment Apr 10, 2026
@martascorreia martascorreia merged commit 70a25e6 into main Apr 15, 2026
17 of 19 checks passed
@martascorreia martascorreia deleted the fix/close-icon-combobox-parts-screenshot-test branch April 15, 2026 12:08
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

fix: 🤔 closable icon of sd-tag inside sd-combobox alignment (parts screenshot test)

9 participants